On 9/27/21 8:31 AM, Richard W.M. Jones wrote: > On Mon, Sep 27, 2021 at 12:15:32PM +0100, Mat Booth wrote: >> On Mon, 27 Sept 2021 at 12:07, Richard W.M. Jones <rjones@xxxxxxxxxx> wrote: >>> >>> A question about this which is semi-related to your email. >>> >>> For some C library packages we have Java bindings, eg: >>> https://github.com/libguestfs/libguestfs/tree/master/java >>> >>> These have been disabled in Fedora for ~2 years, but when they were >>> around they had these BuildRequires: >>> >>> BuildRequires: java-1.8.0-openjdk >>> BuildRequires: java-1.8.0-openjdk-devel >>> BuildRequires: jpackage-utils >>> >>> I believe the only requirements are javac, javah, javadoc (optional) >>> and a JVM to run the tests on. >>> >>> Is it possible to keep this going, or would that require a lot of >>> work? I notice that javah no longer seems to exist. >>> >>> (Note I know almost nothing about how the modern JDK works) >>> >>> Rich. >> >> Hi, the functionality provided by javah has been folded into javac in >> recent JDKs. >> >> These days you can make one call to "javac -h" instead of having to >> call both "javac" and "javah" >> >> I ported quite a few packages this way when Fedora made the switch to >> Java 11 by default. If you like I can probably take a look libguestfs >> and send you a PR? > > Sure thing, thanks. > > However before you start you might also want to know that there are > apparently some serious GC-related problems with how those bindings > work: > > https://bugzilla.redhat.com/show_bug.cgi?id=1536762 > > so it might be more of a saga than just changing a few commands. > > Rich. As the person who reported that bug, I don’t think it is likely to be hit normally. Most of the problems are either poor performance (not using direct ByteBuffers) or potential crashes in low memory conditions (which most users will not run into). I do not believe that any of these crashes are exploitable. That said, I am also unsure if anyone is using those bindings. Why were they added originally? Sincerely, Demi Marie Obenour (she/her/hers)
Attachment:
OpenPGP_0xB288B55FFF9C22C1.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
