On Wed, Aug 18, 2021 at 11:30 PM Jeff Law <jeffreyalaw@xxxxxxxxx> wrote:
On 8/17/2021 8:45 PM, lijiang wrote:
> Hi,
>
> In Fedora crash.spec, currently the LTO is disabled as below:
>
> +# This package has an internal copy of GDB which has broken configure
> code for
> +# INTDIV0_RAISES_SIGFPE and MUST_REINSTALL_SIGHANDLERS
> +# Updating that code properly seems nontrivial and best left to the
> package
> +# maintainer.
> +# Disable LTO
> +%define _lto_cflags %{nil}
>
> commit: c6fc69dae3a2 ("Disable LTO")
So FWIW, those may be non-issues for crash. One of the tests I did when
bringing up LTO was to validate that LTO didn't change the autoconf
detected state for all packages. Those were common failures, but it's
pretty rare that packages really care about those features, especially
INTDIV0_RAISES_SIGFPE -- that test just gets copied all over the place,
but very very few packages actually care.
Thank you for the explanation, Jeff.
This helps a lot.
Thanks.
Lianbo
I didn't know enough about crash or how it uses gdb to be able to make
that decision or how to validate crash's behavior. So the safest
Jeff
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
