Re: older than 30 days and empty side tag clean up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 04, 2021 at 09:46:00PM +0200, Fabio Valentini wrote:
> On Fri, Jun 4, 2021 at 8:58 PM Kevin Fenzi <kevin@xxxxxxxxx> wrote:
> >
> > On Fri, Jun 04, 2021 at 01:07:39PM -0500, Richard Shaw wrote:
> > > On Fri, Jun 4, 2021 at 12:26 PM Kevin Fenzi <kevin@xxxxxxxxx> wrote:
> > >
> > > > Greetings.
> > > >
> > > > Release engineering has just enabled a cron job to remove koji side tags
> > > > that are older than 30 days or have no builds tagged into them.
> > > >
> > >
> > > It would be nice if they automatically deleted themselves after being used
> > > in a Bodhi update.
> >
> > They are supposed to be. koji has:
> > remove_empty = on
> > which is supposed to delete sidetags that are empty.
> > I'm not sure why thats not working, need to file a issue on it...
> >
> > That only handles the empty case tho, not the old.
> >
> > >
> > > Can they be deleted immediately or do we need to wait until the update goes
> > > stable?
> >
> > Should be able to delete them right after the update appears.
> 
> Well, there are two different cases here, aren't there?
> 
> For side tags created for rawhide, they are - in my experience -
> automatically deleted by bodhi once the update goes to stable, shortly
> after it is created.
> 
> For those created for stable releases, I think it makes sense to keep
> them around until the update is pushed to stable, too - otherwise you
> won't be able to edit the update at all. It looks like the bug that
> bodhi didn't delete those side tags after the update is pushed to
> stable has been fixed? At least, all my
> side-tags-for-stable-release-updates-that-are-now-stable are gone.
> 
Is there a race condition here? If e.g. the maintainer takes some time to get
a complicated set of packages all built, and the updates get published to Bodhi
on day 25 ... by the time they get auto-pushed to stable it will be day 32 or 33.

Perhaps side tags associated with an in-progress update should be excluded.

Best regards,

-- 
Michel Alexandre Salim
profile: https://keyoxide.org/michel@xxxxxxxxxxxxxxx

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux