On Tue, Feb 16, 2021 at 03:38:35PM +0100, Fabio Valentini wrote: > On Tue, Feb 16, 2021 at 3:01 PM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote: > > > > On 16. 02. 21 14:48, Fabio Valentini wrote: > > > if version_at(commit) != last_version: > > > return 0 > > > > Should this be "return 1"? > > No, 0 is correct. If the version does not match, this is the last > commit *before* a version update. > The "max(parents) + 1" then sets the Release to 1 for the commit that > actually changed the version :) > > > To prevent accidental divergence between the git history and the build system. > > That's why this information is only used in the koji plugin, locally (ie: via > > the rpmautospec CLI) it only relies on the git tags. > > So ... you want to *prevent* divergence by *introducing* divergence? I > do not follow ... The build information is used to check if all the builds made in koji exists as tags. If they don't, then they are added, thus resolving the divergence. If they do, git tags are used, just like they are used locally. Pierre _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
