On Fri, 2021-01-08 at 23:26 +0100, Miro Hrončok wrote: > On 08. 01. 21 23:24, Matthew Miller wrote: > > On Fri, Jan 08, 2021 at 09:34:29PM +0100, Kevin Kofler via devel wrote: > > > > So if anything, I think this change is in line with your views here. > > > > > > Well, if (and as long as) the gating only blocks the autopush and does not > > > prevent a manual push (as yet another requirement), I withdraw my objection. > > > > I think we should get to the point where it blocks manual pushes (without > > the failure being waved). If the test is broken, fix the test. > > That is easier said than done. What if the failure is unrelated to my update? I'm essentially committing us to making sure it won't be. As I explained in the initial email, I already do this quite conscientiously. The only way this can be the case is if an update which causes a test failure gets pushed stable. Either the update is tested but the failure is disregarded and the update pushed (which this proposal will make *less* likely, but not impossible, since failures can be waived) or the problem is introduced by an update that isn't tested (this is unusual but does sometimes happen). Neither of these things happens terribly often. When one does happen, I treat it as a high priority to get it fixed or worked around and re-run all non-related tests that were affected by it. And, of course, we *can* waive failures if all else fails. -- Adam Williamson Fedora QA IRC: adamw | Twitter: adamw_ha https://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
