On Thu, 2021-01-07 at 11:23 -0800, Adam Williamson wrote: > On Thu, 2021-01-07 at 18:48 +0000, Mattia Verga via devel wrote: > > Il 07/01/21 18:25, Adam Williamson ha scritto: > > > ...snip... > > > > > > Implementing this would be relatively simple, and would involve two > > > things: adding some new bits to Fedora's greenwave policy definition, > > > and patching Bodhi to use a different decision_context for greenwave > > > queries for non-critpath updates and critpath updates. I could have > > > both those changes ready for review in a day, probably. It would be > > > equally simple to revert the change if it turned out to be a bad idea. > > > > > > ...snip... > > > > I thought it would just require to add a gating.yaml file to src.fpo > > package repository listing the required tests to pass for gating be > > effective. Isn't that so? > > Well yes, but that wouldn't be a sensible way to do this, as we'd have > to do it for *every single package* we wanted to gate. Which is > hundreds, I think. > > That mechanism is intended for tests applicable to single packages or > small groups of packages. At this scale it makes more sense to amend > the project-wide policy, as I proposed. That file is: > https://pagure.io/fedora-infra/ansible/blob/master/f/roles/openshift-apps/greenwave/templates/fedora.yaml > if you're interested. ...oh and actually there's another very in-the-weeds reason that wouldn't work, which is commented in that file: # The "remoterule" policy applies policies configured in individual # package repositories. See Greenwave docs/policies.rst and # https://docs.fedoraproject.org/en-US/ci/gating/ for details. Note # we don't have a remoterule policy for bodhi_update subject type # because Greenwave doesn't consider it to support remote rules. those in-repo policies can actually only be used for tests that run at the *package* level (the 'koji_build' 'subject_type', in Greenwave's terms). In practice, that means tests than run in Fedora CI. As the system currently works, you actually can't use a per-repo policy to gate on tests that run at the *update* level (in practice, openQA tests). It would be possible but not *entirely* trivial to change this. -- Adam Williamson Fedora QA IRC: adamw | Twitter: adamw_ha https://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
