On Tue, Aug 25, 2020 at 11:19:57AM +0200, Miro Hrončok wrote: > On 25. 08. 20 10:51, Fabio Valentini wrote: > > On Tue, Aug 25, 2020, 10:45 Miro Hrončok <mhroncok@xxxxxxxxxx > > <mailto:mhroncok@xxxxxxxxxx>> wrote: > > > > On 25. 08. 20 5:52, Michel Alexandre Salim wrote: > > > I'll properly retire lua-logging and luadoc, but keep lua-sql. > > > > Let's merge the retirement commits to f33 as well? > > > > > > Doesn't "fedpkg retire" do more than just push something to git, e.g. > > publish retirement information to PDC or something? So IIUC just merging > > the retirement commit to f33 won't be enough since it won't block the > > package in koji. > > It used to (with pkgdb) now it doesn't. It emits a commit message with 'dead.package' in it. This is listened for by https://pagure.io/fedora-infra/toddlers/blob/master/f/toddlers/plugins/pdc_retired_packages.py which marks the package eol in pdc. Then, the next rawhide or branched compose runs https://pagure.io/releng/blob/master/f/scripts/block_retired.py which looks in pdc and for every package that is eol in pdc it blocks it in koji. > This is how I retire orphaned packages between branching and beta freeze: > > fedpkg clone $pkg && \ > cd $pkg && \ > fedpkg switch-branch f33 && \ > fedpkg retire "Orphaned for 6+ weeks" && \ > fedpkg switch-branch master && \ > git merge f33 && \ > git push > > (There used to be a rule to retire older branches first, but I suppose that > is no longer required and the command might be simplified.) > > It works fine (except for a slight period when retirements on f33 were > broken, but that was a server side issue, not the command). Either way should work, it's looking for the commit, merge or not. kevin
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
