On Tue, Aug 04, 2020 at 12:02:05PM +0200, Florian Weimer wrote: > * Daniel P. Berrangé: > > > Taken from https://koji.fedoraproject.org/koji/taskinfo?taskID=48525923 > > Sorry, what would be more interesting is the linker invocation. The > build log does not show this, only the libtool invocation. We don't > really know what kind of transformations libtool does in this case. Upstream libvirt has just yesterday replaced use of autotools with meson. I just tried a Fedora rawhide build of our new meson based code and it succeeded with LTO. Given this, I think I'm fine just disabling LTO in rawhide for the current libvirt release, with the expectation we'll re-enable LTO in ~1 month time when we import the meson based release of libvirt. IOW lets not waste any more time debugging this LTO / LD_PRELOAD problem with libvirt. > libtool is really not built for LTO, and it really should not be used on > GNU systems. But I understand that this is not uncontroversial. There's oooh so many problems with libtool we've hit over the years, especially with it re-arranging order of compiler/linker flags, and so I'm beyond ecstatic that we've finally thrown it away for libvirt in favour of meson. There may have been a time & place for libtool and autotools in general, but that time has passed.... Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
