On 7/1/20 9:49 PM, Chris Adams wrote:
Once upon a time, Josef Bacik <josef@xxxxxxxxxxxxxx> said:
This sounds like a "wtf, why are you doing this btrfs?" sort of
thing, but this is just the reality of using checksums. It's a
checksum, not ECC. We don't know _which_ bits are fucked, we just
know somethings fucked, so we throw it all away. If you have RAID
or DUP then we go read the other copy, and fix the broken copy if we
find a good copy. If we don't, well then there's nothing really we
can do.
That's where an fsck and a lost+found type directory should come into
play. Maybe punt to user space, but still try to see what you can make
sense of to try to salvage. If you are saying a single bit error in the
wrong place can basically lop off a good chunk of a filesystem, then I'm
going to say that's not an improvement in reliability.
We do, the recovery tools allow you to just ignore checksums. This is
specifically separate from everything else because there's the expectation of
results. The user is acknowledging that things are bad and the tools are going
to do their very best. If you know you only have a single bit off then hooray,
you got everything back (probably), but if not then you don't. Thanks,
Josef
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
