-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Thu, 2020-07-02 at 12:20 +0200, Nicolas Mailhot via devel wrote: > Le 2020-07-02 11:59, Florian Weimer a écrit : > > * Nicolas Mailhot via devel: > > > > > Le 2020-07-02 09:59, Vitaly Zaitsev via devel a écrit : > > > > On 02.07.2020 07:35, Nicolas Mailhot via devel wrote: > > > > > The detached changelog is just one more file in SRPM sources, > > > > > which > > > > > is > > > > > modified by rpmbuild at `%build` time with other files > > > > > rpmbuild > > > > > modifies. > > > > > > > > I don't like that. %changelog should be generated automatically > > > > on > > > > Koji > > > > side. > > > > > > Why? Koji schedules a build. > > > > No, Koji also builds the SRPM, via fedpkg-simple or a similar > > mechanism. > > Sure, by build I intended both the deployment packages and the SRPM. > > The main difference between the current workflow (the reason it fails > in > mock right now, but that should not be too hard to fix) is that the > SRPM > that includes the build info is itself a result of the rest of the > build. > > That seems the main point people misunderstand (thank you for making > me > clarify it), the proposal does not involve preparing a special SRPM > out > of band, that is then fed to koji, the SRPM containing the bumped > changelog and last build info is the result of the build process > alongside the binary packages. > > mock (and koji) just have to pick this SRPM at the end of the build > and > not use the SRPM as it existed before the build occurred. So who is going to implement necessary changes in mock and koji for this proposal to be complete? > And why is it that way? You do not consider a rpmbuild -bs a build > event > do you? We do it all the time to import packages from one system to > another. The only thing which is a real build that produces a bump > and > is stored in changelog history is a full rpmbuild -ba build. > > Regards, > > -- > Nicolas Mailhot > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx - -- Igor Raits <ignatenkobrain@xxxxxxxxxxxxxxxxx> -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcwgJ58gsbV5f5dMcEV1auJxcHh4FAl79uiIACgkQEV1auJxc Hh6DWA//QXrE2wOef89QaKs/2KW9boWCZu3uapwHC+479iB2b1E3J7iw5c1JW03s 0BQ9sk+blA7WntICR2ebkq+wjv5A8upLDj7OGABxIag04MlMHXKD3HZtT67QoMUi vNEdxHr98oim7S/wI5ZizAAjxFApVoZmpsokaATc0r32wcyczVsWvBxEYmjw7Uo6 QqN38o/Z8Y9xaTDHf/S4d+FTUTbKmetpLmb5tLg25m62+0GaFMpfYo0lCuFID2on Ionk7+b0LH8DHaacxBwoV+6HiOno+qYLqDBLOKh5kJGFGr+o33uqqTfc3/7KouZh ui9F7TxeRpd+bbVhfQbAdQZEIWQCVaFSIza8YN8mXe6jcyyqqWjUOhWgGt6ihaSs h255wdI8VcZJXTSYt+qkXj5Z6fGvvDXjD+AoEtFyhP9sqm5qmFyEIm7xE/NGwFMj BO6xIumEFavP6lEylFtYH9j6q9LFvYBB5ITw33jI4Wq/lYbD4cB96ksuzz1FvDzp R76Y10H0naFmqN0IdLC7L8LV45uXFg/jZ0NCLQ/6d0kUm/FbggmhpePzJUZI/b3T phokAdf0RQ32NXXRj/unK8yMwaZfFd8ec+UK4VFb1+pECjgyvGxojp+vo7pVzEu8 QCTy+Cb5T96mwfO9ejFQMGV2VZBBoVPYsGc0hTmg4j7eA7fPiE8= =FeYg -----END PGP SIGNATURE----- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
