On Tue, 2020-06-23 at 18:26 +0200, Tomas Hrnciar wrote: > Hello everyone, > > there are plenty of Python packages in Fedora currently using > setuptools at > buildtime but not all of them are BuildRequiring it explicitly. This > only works > because python3-devel (transitively) depends on python3-setuptools. > > We would like to kindly ask you to add explicit BuildRequires for > python3-setuptools to packages where setuptools is used. It will help > us > with testing new versions of setuptools in the future or with > decoupling > Python and setuptools. Today, if we want to know if a package is > using > setuptools, we have to do `fedpkg prep` and use grep to search for > setuptools. Using a repoquery is much more convenient. > > Several packages can successfully build either with or without > setuptools > (they use try-except import and fallback to distutils from the > standard > library). Such packages are especially dangerous when not > BuildRequiring > setuptools -- they can produce different results depending on the > presence > of setuptools: either an .egg-info metadata directory (w/setuptools) > or > .egg-info text file (w/distutils). RPM has troubles when upgrading > directories to files [1]. IMBW, but I think I recall the Python packaging guidelines specifically said that you could or should (I forget which) just BR python-devel and not BR python-setuptools at some point. At this point there seems to be no explicit mention, but the sample spec file looks a lot like a project that uses setuptools, but does not explicitly BuildRequire it... -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
