Dne 06. 05. 20 v 11:19 Tomas Tomecek napsal(a): > On Tue, May 5, 2020 at 6:16 PM Miro Hrončok <mhroncok@xxxxxxxxxx> wrote: >>>> In what way does keeping the spec file in our fork help us? >>> (speechless for like a minute) >> I don't really understand this comment. Speechless because our workflow is tedious? > I just couldn't understand why you are asking me about source-git when > you already track your downstream patches as git commits :D > >>> Don't you wanna create (S)RPMs out of that repository? Don't you wanna >>> be sure that when you add a change to that repository it builds fine >>> on rawhide and the latest stable fedora? >> That would be cool. I don't understand why do I have to keep the spec file in >> there for that. > You don't. > > With these ~20 lines you can get RPM builds for every PR in chroots of > your choice: > > https://github.com/TomasTomecek/cpython/pull/1 This is a bit of irony: ~~~ post-upstream-clone: - curl -O https://src.fedoraproject.org/rpms/python3/raw/master/f/python3.spec - curl -O https://src.fedoraproject.org/rpms/python3/raw/master/f/idle3.appdata.xml - curl -O https://src.fedoraproject.org/rpms/python3/raw/master/f/idle3.desktop - curl -O https://src.fedoraproject.org/rpms/python3/raw/master/f/check-pyc-timestamps.py # packit will apply the patches itself - sed '/^Patch/d' -i python3.spec # patckit uses %autosetup - and yes, the line below doesn't make sense given # how python3's spec look, this is just a demonstration of packit's functionality - sed '/^%patch/d' -i python3.spec ~~~ So why does not Packit do this by itself? Just the `curl -O https://src.fedoraproject.org/rpms/python3/raw/master/f/python3.spec` should be kept in some form .... Vít > > (the build is failing, even SRPM can't be created, seems like there is > a file in the repo which can't be processed by tar & gzip, need to > take a closer look) > > The spec file is being fetched from rawhide's dist-git for every > build. Your use case is a little bit more complex since you patch > conditionally so we'd probably need a mechanism in packit: > 1. not to add 'Patch: 0001...' lines into spec > 2. not touch %setup line > 3. and map respective git commits to Patch lines within a spec > > so that all would work well for your use case - there are also > different ways how to solve it but that would be a lot of typing > > > Tomas > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
