On 05. 05. 20 8:43, Panu Matilainen wrote:
Hmm, OTOH this is a bit questionable: macro primitives can only take arguments
in the %{foo:bar} form, so perhaps the non-%{} form actually
should fall through silently.
OTOH I'd argue anything that resembles a macro, even if nonexistent, should fail
immediately if not used properly. That means people will be forced to stop
accidentally using %stuff in their specfiles waiting for the moment somebody
creates a macro of that name.
If we want to avoid mass breakage, maybe at least issue a waening.
I'd consider this useful:
warning: unescaped % in line 666: %HH, macro %HH doesn't exists
As a side note, I don't consider this useful:
warning: extra tokens at the end of %endif directive in line 1073: %endif #
with tests
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx