On Fri, 1 May 2020 at 13:39, Dan Horák <dan@xxxxxxxx> wrote: > > On Fri, 1 May 2020 13:21:10 +0200 > Iñaki Ucar <iucar@xxxxxxxxxxxxxxxxx> wrote: > > > Hi, > > > > I forked a package, changed the spec, added a patch and submitted a > > PR. Then simple-koji-ci fails because the patch wasn't included in the > > SRPM apparently [1]. Any idea why? Did I miss something? > > > > [1] https://src.fedoraproject.org/rpms/R/pull-request/3 > > The problem is that the CI creates the srpm on F-30, but then runs it > against F-31. And your specfile doesn't include the patch into the srpm > for F<31. And that's why you shouldn't hide the Patch2 definition > behind a condition. I see, thanks. Iñaki _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
