Re: simple-koji-ci fails with new patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 1 May 2020 13:21:10 +0200
Iñaki Ucar <iucar@xxxxxxxxxxxxxxxxx> wrote:

> Hi,
> 
> I forked a package, changed the spec, added a patch and submitted a
> PR. Then simple-koji-ci fails because the patch wasn't included in the
> SRPM apparently [1]. Any idea why? Did I miss something?
> 
> [1] https://src.fedoraproject.org/rpms/R/pull-request/3

The problem is that the CI creates the srpm on F-30, but then runs it
against F-31. And your specfile doesn't include the patch into the srpm
for F<31. And that's why you shouldn't hide the Patch2 definition
behind a condition.


		Dan
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux