On Sun, Mar 08, 2020 at 12:15:23PM +0100, Dan Horák wrote:
On Sun, 8 Mar 2020 10:59:19 +0000
Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote:
Hi,
for a recent systemd build, the automated tests results showed
failure [1], and one of the failing tests was
fedora-ci.koji-build.rpminspect.static-analysis.
When I click on the label, I get redirected to [2], which is a long
list of stuff like "print message" and "shell script" and "ci
notifier". They are all green, and after clicking on one of them to
unroll it, the display jumps, so it took me a while to figure out
that the interesting item is one of the "shell scripts". Dunno, when
doing this a second time I wouldn't be confused so much, but a
slightly less elaborate UI which makes the failing test result more
prominent would be nice.
[1] https://bodhi.fedoraproject.org/updates/FEDORA-2020-b49f1d9b82
[2]
http://fedora-build-checks.apps.ci.centos.org/blue/organizations/jenkins/fedora-rpminspect/detail/fedora-rpminspect/3219/pipeline/
Anyhoo, getting to the failing test:
there's a long list of two repeated items:
[2020-03-06T13:45:51.450Z] rpminspect output for humans - see
rpminspect.json for full details [2020-03-06T13:45:51.450Z] Overall
Result: NOT PASSED [2020-03-06T13:45:51.450Z] NOT PASSED items:
[2020-03-06T13:45:51.450Z] header-metadata:
[2020-03-06T13:45:51.450Z] message: Package Build Host "unused"
is not within an expected build host subdomain in
systemd-tests-debuginfo-245-1.fc33.s390x
[2020-03-06T13:45:51.450Z] remedy: Make sure the SRPM is built on
a host within the expected subdomain.
Seems fully bogus? "unused" might be a placeholder value, but even
if it wasn't, we have a dedicated server farm to build things.
As a packager, I don't have any control over the hostname of the
builder and I shouldn't ever need to care.
[2020-03-06T13:45:51.451Z] elf-object-properties:
[2020-03-06T13:45:51.451Z]
message: /usr/lib/systemd/tests/test-dhcp-client may use functions
unsuitable for IPv6 support on s390x [2020-03-06T13:45:51.451Z]
remedy: Please review all usages of IPv4-only functions and ensure
IPv6 compliance.
I understand the sentiment, but what is "functions unsuitable for IPv6
support on s390x"? I'm not a s390x expert, and the code is using
general linux apis. Is this message talking about some s390x-specific
bug? How am I supposed to figure this out, without any function name
or hint what to look for specifically? (Obviously, in the case of a
test binary for DHCPv4, it might be fully legitimately using
IPv4-only constructs…).
FWIW the message is repeat for all arches, so nothing s390x specific
here
The arch-specific warning is an idea I took from rpminspect's ancestor. In
some instances it works well but in other instances it generates repetitive
noise. I'm working on a way to better consolidate messages like that.
Thanks,
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat, Inc. | Boston, MA | EST5EDT
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
