"Colin Walters" <walters@xxxxxxxxxx> writes: > On Wed, Oct 2, 2019, at 1:40 PM, Fabio Valentini wrote: > >> As others in the thread have pointed out, mandatory pull requests >> just make no sense for most single-maintainer projects, which most >> packages probably are. > > Well, a lot of this relates to what the *merge policy* is. If a PR > submitter can merge their own PRs, and there's a mechanism to do > "merge when tests pass" (this is an important aspect), then submitting > a PR can be just about as equally ergonomic as `git push`. With about six more emails about it, sure. And another piece of infrastructure that has to be up and bug-free. Even the gating and bodhi emails today are rather a lot: I don't want to be notified if everything worked correctly. > In OpenShift we use Prow, which has the latter; I really like it. > However we also *require* peer review (submitters can't merge their > own PRs). I'd like to require review, but it does seem like a > prerequisite is moving away from the one-repo-per-package model. It also requires people to do the review, which many packages don't have. For many teams, this would more than double the time spent on packaging. That's not tenable. Thanks, --Robbie
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
