Hi mufti, On Tue, Jul 30, 2019 at 8:02 AM J. Scheurich <mufti11@xxxxxx> wrote: > | Review the package .. > | * Go through the MUST items listed in Review Guidelines > <https://fedoraproject.org/wiki/Packaging:ReviewGuidelines> . > | * Go through the SHOULD items in Review Guidelines > <https://fedoraproject.org/wiki/Packaging:ReviewGuidelines> . > | * The FedoraReview <https://fedorahosted.org/FedoraReview/> tool > (packaged as fedora-review) can help to automate this process. > | * Include the text of your review in a comment in the ticket. For easy > readability, simply use a regular > | comment instead of an attachment. > > I didnt't include the text of the review, cause i thought, potential > problems has to be solved first 8-( You can mention all the issues you have found with the package you are reviewing at once. No need to do it piecemeal, unless we are talking about something fundamental, e.g. patent-encumbered code, that can't be in Fedora. > Sometine others (who can do a real review), added the text of the > review, some others wrote > something like: > > "I have manually reviewed this package, and it is APPROVED. It conforms > to the Fedora Packaging Guidelines, and is under an acceptible license. > It builds cleanly in Rawhide." I believe that in these cases, there was a problem with fedora-review. Keep in mind that while fedora-review minimizes the effort you need to put in, you must go over all the items listed, to check for false positives or issues that the program could not assess. > Is it ok for a informal review, to send the text of the review, if some > other reviewer also included > the text of the review ? If someone has already gone through the checklist, but there is still something missing, there is no need to reiterate the issues that have already been addressed. Having been on the receiving end of the process myself, I always found it helpful to have the checklist at some point, because more often than not, there were issues that had escaped my attention. Several times, I've had reviewers pasting in later comments the bits of the template that I had forgotten to fix. Another advantage of using the template is that the text is pretty clear-cut and self-explanatory. Use common sense and you'll be fine. By the way, before you start commenting on the particulars of each package, you should notify people that you are doing an informal review, so as to avoid frustration and they know to keep looking for a sponsor. Best regards, A. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
