Re: Fedora 31 Self-Contained Change proposal: Limit Scriptlet Usage of core packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 22, 2019 at 07:25:50AM -0400, Neal Gompa wrote:
> On Mon, Jul 22, 2019 at 4:00 AM Zbigniew Jędrzejewski-Szmek
> <zbyszek@xxxxxxxxx> wrote:
> >
> > On Sun, Jul 21, 2019 at 01:03:59PM -0400, Neal Gompa wrote:
> > > On Mon, Jul 15, 2019 at 11:52 AM Zbigniew Jędrzejewski-Szmek
> > > <zbyszek@xxxxxxxxx> wrote:
> > > >
> > > > On Mon, Jul 15, 2019 at 10:13:21AM -0400, Neal Gompa wrote:
> > > > > On Mon, Jul 15, 2019 at 10:04 AM Miroslav Suchý <msuchy@xxxxxxxxxx> wrote:
> > > > > >
> > > > > > Dne 10. 07. 19 v 9:19 James Antill napsal(a):
> > > > > > > 2. adduser/group/etc. => sysusers files
> > > > > >
> > > > > > For anyone willing to do this in advance on his/her package - this is how you can do that:
> > > > > >
> > > > > > https://github.com/rpm-software-management/mock/commit/cf4c8f076637755acc3cf4eb091d8ebb36020237
> > > > > >
> > > > > > Here is relevant FPC ticket:
> > > > > >   https://pagure.io/packaging-committee/issue/442
> > > > > >
> > > > > > Just for the record - this does not make things to run faster. You still have to have %pre scriptlets. It is likely even
> > > > > > slower as you are running %posttranstrigger as well. The benefit is here only that we move toward declarative specification.
> > > > > >
> > > > >
> > > > > That’s also going to fail, because the %pre script executes before the
> > > > > file exists. That’s why these guidelines are broken, and why I
> > > > > suggested we deal with sysusers differently.
> > > >
> > > > Oops, you're right. As /usr/lib/rpm/macros.d/macros.systemd says,
> > > > %sysusers_create is "deprecated. Use %sysusers_create_package instead".
> > > >
> > >
> > > And to note, even this change doesn't work:
> > > https://github.com/rpm-software-management/mock/commit/6bb017f7a5a62bcdec2ae18d18d6d090928f9084
> > >
> > >
> > > The reason it doesn't work is because this scriptlet will fail to
> > > locate the file needed to actually do this. The macro was written in
> > > mind for being pointed to the file in the sources directly, rather
> > > than having a path to assume.
> >
> > Can you explain what exactly is wrong? It looks OK to me.
> >
> 
> How is it supposed to find the mock.conf sysusers file?
> %sysusers_create_package expects you to tell it where the file is so
> that it can be parsed and expanded at package build time. That's not
> being done here...

Well, the file in this case is given as "mock.conf", and I see a file
with this name in the same directory as the spec file, so everything
seems to be in order.

Zbyszek
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux