On Thu, Jun 6, 2019 at 3:08 PM Dennis Gilmore <dennis@xxxxxxxx> wrote: > > On Thu, Jun 6, 2019 at 7:11 AM Neal Gompa <ngompa13@xxxxxxxxx> wrote: > > > > On Thu, Jun 6, 2019 at 7:53 AM Florian Weimer <fweimer@xxxxxxxxxx> wrote: > > > > > > Is there a reason why we do not tag dist-git commits, using a name which > > > is derived from the NEVR from a Koji build? > > > > > > How well does Git scale with thousands of tags? > > > > > > > We used to back in the CVS days, because we needed it for plague. Koji > > blocks duplicate submissions anyway, so it stopped being needed when > > we transitioned to Git. > > it was not plague that needed it, using tags was the only way to > cjeckout the intended output, they had the problem that they were not > immutable, if you made a typo you forced in a new tag so you did not > need to bump the nvr > > > We're going to probably introduce it for some automation in the near > > future, though. > > > > Git is not great with thousands of any kind of refs, be it branches or > > tags. It still works, it's just things like 'git log' get kind of > > expensive. > > koji stores the git hash for all builds, writing a script to get the > hash for a given nvr would be trivial. it just means you have to be > online to retrieve the data than being able to get the date while > disconnected, if it was stored in git. Might be worth asking if there's a reason to need this offline. If the exact commit ID is stored in Koji and is authoritative, also tagging it into git might be convenient for offline purposes. The fact that it's not immutable is probably not an issue as long as the authoritative site *is*. (e.g. The same script that gets the hash from Koji could also detect if someone manually changed it in git, which would probably qualify as suspicious behavior.) _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
