On 5/28/19 1:57 AM, John Reiser wrote:
if ((t&=7)==0) *++ib=0; int a; (*vs_) >> a; if (a) *ib|=static_cast<unsigned char>(1<<(7-t)); }
Such code is an abomination for lack of clarity.
Also, the preceding line
for (int x=0,t=0; x<xs*components_; ++x,++t) {
suggests that (7 < t) is a possibility, so (1<<(7-t)) will be undefined,
and the run-time bug will be hard to find.
Isn't t forced into 0..6 by the t&=7 evaluation in the first if?
--
Roberto Ragusa mail at robertoragusa.it
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
