On Wed, 2019-04-24 at 12:11 -0700, Adam Williamson wrote: > On Mon, 2019-04-22 at 10:49 -0700, Samuel Sieb wrote: > > On 4/22/19 9:25 AM, Adam Williamson wrote: > > > AIUI, the design is that any package that *ships a preset* should run > > > systemctl preset on it in its scriptlets (there should be guidelines > > > for this somewhere but I can't find them right now). However, there's a > > > loophole here in that if any package that ships a preset gets ordered > > > before systemd itself during install, its attempt to run 'systemctl > > > preset' will obviously fail. This is why we run 'preset-all' in the > > > systemd package scriptlets: to apply the presets for any packages which > > > were already installed. It's not intended that all other packages can > > > *rely* on the call in systemd's scripts. > > > > > > So, basically: if you're making a package that includes presets, run > > > 'systemctl preset' on the presets it ships in its scripts. Not 'preset- > > > all', but run it specifically per preset that you ship. > > > > Couldn't you run the preset script in a %posttrans block to ensure > > everything is installed? > > I mean, in theory, yeah. I don't know for sure if there's a reason why > this isn't done, or even if it's been specifically considered. ...though of course this would *solely* function as a sort of 'safety valve' for install system installation, because a package including a preset can always be installed *after initial system installation* and that situation still has to be handled, which a systemd %posttrans script obviously doesn't do. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
