On Mon, Apr 8, 2019 at 1:39 PM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote:
That's not how I read it: https://github.com/mesonbuild/meson/blob/master/docs/markdown/Builtin-options.md#base-options -DB-ndebug defaults to false.
OK, then I was totally wrong, thanks. Shame the docs are so hard to search through. :(
Again, this setting should be set per project, so reverting the change was the right call IMO.
OK, I agree now. Since it's off by default in meson upstream, we shouldn't be turning it on in Fedora. Sounds like reverting is the right move.
With the above in mind, I consider mesa's meson build system to be broken for incorrectly assuming distros will use -Db_ndebug=if-release or -Db_ndebug=true, since we will not be doing that. So mesa should find another way to ensure its performance-sensitive asserts are not enabled in plain builds (or release builds). Right? We can of course work around the issue in the Fedora spec by using -Db_ndebug=true just for mesa.
Michael _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
