Re: Reviewing a package with an rpmfusion dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On vendredi 15 mars 2019 04:53:39 CET Jerry James wrote:
> I was just looking at reviewing this package:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1684950
> 
> It is a Go wrapper around ffprobe, which is in the ffmpeg package,
> which is in rpmfusion-free.  The package can be built without ffprobe,
> but cannot be used without it.  The spec file contains this:
> 
> # We can't have a hard dependency because patents
> Recommends:     ffmpeg
> 
> Really, this package should have "Requires: ffmpeg", because it cannot
> be used at all without ffprobe.  So I think this package should not be
> in Fedora, but in rpmfusion instead, and that the review request
> should be denied.
> 
> Thoughts?

That library is needed by golang-github-anacrolix-dms, which states:

dms uses ffprobe/avprobe to get media data such as bitrate and duration, 
ffmpeg/avconv for video transoding, and ffmpegthumbnailer for generating 
thumbnails when browsing. These commands must be in the PATH given to dms 
**or the features requiring them will be disabled.**

So the dependency to ffprobe is optional: some of the functionalities will be 
available but not all.

All of these packages are dependencies to Rclone 1.46 which needs to be 
updated in Fedora.




_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux