On Thu, 2019-01-17 at 11:13 +0100, Miro Hrončok wrote: > It happened to me almost dozen times now, so here's my rage :D > > I want to send a pull request to a Fedora project*, I clone it, fork it, push to > the fork, open a PR and there it goes: > > ! This repo requires all commits to have the Signed-off-by whatnot in them ! > > So I have to go again, amend with -s, push force. That is tedious and at least I > know how to do that. I assume there are people who don't. > > Can we stop this nonsense? I usually smuggle something like: > > Signed-off-by: Stop This <pretty@xxxxxxx> > > And nobody ever cares! The thing is enforced only because it can be enforced. > > The line in that commit message is totally useless and doesn't provide any > benefit, just pain. I've signed the Fedora Project Contributor Agreement. That > should be enough. > > Now a bit more serious: > > What information am I missing? Why do Fedora upstreams enforce this? If you look in any of my projects' READMEs, you'll see the 'developer certificate of origin' text available at https://developercertificate.org/ . There's a good write-up on the DCO on opensource.com: https://opensource.com/article/18/3/cla-vs-dco-whats-difference *In combination with the DCO*, the sign-off is meaningful (and yes, I do check that it's actually consistent with the person submitting it when I review PRs). If a project is enforcing sign-off but doesn't have the DCO or any other kind of prominent statement of what the sign-off is *for*, that is meaningless, because there's no reasonable context for the sign-off text. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
