Re: fedora-review — do we have a maintainer?

[Kamil Paral <kparal@xxxxxxxxxx>]

On Thu, Aug 16, 2018 at 2:31 PM Michal Novotny <clime@xxxxxxxxxx> wrote:

On Thu, Aug 16, 2018 at 10:49 AM Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote:

f-r currently fails to build (#1603956), it has a bunch of bugs open [1]
and many issues and unhandled pull requests in the upstream repo [2, 3].
The last upstream commit was 2 years ago.

f-r has is annoyingly outdated and gives often outright bad advice
(for example about BR:gcc or BR:g++). The situation would be significantly
improved if the outstanding PRs were merged.

f-r is also python2-only now, which will be a problem soon since
support for python2 is waning [4].

Is there any hope of upstream and downstream activity on f-r?

I was thinking about getting the fedora-review checks rewritten into the standard Test interface

(https://qa.fedoraproject.org/docs/libtaskotron/latest/standard-test-interface.html) so that they

can be run in Taskotron. We can also just probably run one big fedora-review check from

a taskotron test, well, this just came to my mind recently, getting the actual solution ready

might take a little bit of time.

I was actually thinking about this some time ago. If there's a responsive fedora-review maintainer who can respond to people's questions and complains (because if we start running it for every package build and show it in Bodhi, there will be some), I can help to make it run as a Taskotron task. The STI can be just a simple wrapper around the fedora-review binary that downloads the build, runs the command, and generates the results format. It should be similar to rpmlint etc tests we already have in there.

The important question is - can it be executed on existing SRPMs/RPMs? We don't want to (and probably can't afford to) build the packages from scratch inside Taskotron tasks. But we could run an analysis on an already completed Koji build.

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/NO5UZJCUGYKCMPR5LOLIAJ6ZHBK4ECAI/