Yuck. So you are recommending using 14 lines (with comments) of spec file goop that uses 2 %ifarch build section tests in order to set/unset a macro. There's further baggage in spec files needed to add a BR, pass an option to configure, add libraries to link, etc You are in the wrong namespace testing arch in spec files to determine +/- valgrind. To illustrate what I am saying, consider endianness. There was a lot of code that used to test the vendor "sun" or the platform "VAX" in order to determine endianness, all of which had to be patched when circumstances changed and Solaris was released for ix86. Your 14 line example will suffer a similar fate if valgrind is fixed to run on ppc64, or ppc64 aliases start to proliferate. There is a need to refactor all of this framework to simplify building packages with or without a subcomponent like valgrind that does not use explicit test on arch to imply +/- valgrind subcomponent. Gentoo manages this quite well with XML and inheritance instead of explicit logic. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/3KXHXM5QLL7NOH7BUJTLA5DU5GWEIMC7/
