On Friday, July 27, 2018 10:01:42 AM CEST Miro Hrončok wrote:
> On 27.7.2018 07:55, Pavel Raiskup wrote:
> > On Thursday, July 26, 2018 2:29:17 PM CEST Miro Hrončok wrote:
> >>> Please, either make sure that %py_byte_compile doesn't collide with the
> >>> default byte compilation machinery, or change the default right now (and
> >>> define the '%_python_bytecompile_extra 0' in batch). The former is
> >>> preferred of course.
> >>
> >> How does it collide exactly?
> >
> > I'm not sure. Can I simply use %py_byte_compile without
> > '%_python_bytecompile_extra 0'?
>
> You CAN use %py_byte_compile anywhere. With or without
> '%_python_bytecompile_extra 0'.
>
> You MUST use '%_python_bytecompile_extra 0' if you have /usr/bin/python
> in buildroot and you DON'T want it to be used to bytecompile Python
> files outside of Python dirs.
So from your note it looks like the /usr/bin/python can cause troubles?
Consider:
- I have /usr/bin/python in buildroot mistakenly
- I do some explicit %py_byte_compile some files in %buildroot in
"extra" dirs, by either python3 only or both python{2,3}
- I don't explicitly set '%_python_bytecompile_extra 0'
Then, brp-python-bytecompile goes and recompiles (by /bin/python) those
files, right? But where's the problem? Python2 and Python3 store the
byte compiled files to different directories... (yes,
brp-python-bytecompile could avoid recompiling files which are alrady
compiled, but that's detail).
Yes, I see a very low-prio issue -> if the package is Python 3 only, it
can get inadvertently installed python2 '*.pyc' files. But that's only
small issue (size of RPM) and it's temporary issue (we plan to turn
%_python_bytecompile_extra to 0 system wide soon).
Pavel
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/JODS5TTYVKMY2VLEHHIJ6DM5EA7TPAXL/
