On Tue, Jul 24, 2018 at 07:06:49PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 24, 2018 at 01:32:45PM -0400, Todd Zullinger wrote: > > Artur Iwicki wrote: > > > That section of the guide is a bit poorly worded. You should *not* use "git add" on source tarballs. These should be added only via means of "fedpkg new-sources $FILES; git add ./sources". I believe what the guide means under "new source files" is e.g. when upstream does not provide an icon or a .desktop or an .appdata.xml file (or a systemd .service or whatever) and you add your own. This does not include "new upstream release tarball". > > > > > > I'll try to think of some way to make that more clear and submit a suggestion to change the guide text. > > > > Somewhat tangentially, it may be worth recommending that the > > .gitignore be edited suitably for the project as one of the > > first steps in maintainence. > > > > By default 'fedpkg sources' will add the files being added > > to the lookaside cache to the .gitignore, but it will never > > remove older files, leading to an unnecessarily large > > .gitignore file. > > It probably isn't unreasonable to file an RFE against fedpkg to request > more intelligent behaviour. eg given a tarball filename in majority of > cases it is likely quite straightforward to identify the base name > eg match the filename against something like this > > (\w+)-(\d+(\.\d+)*).(zip|tar.\w+|tgz) > > And replace the 2nd part of the regex match with '*' to form the rule > to add to the .gitignore file. Can't this be inferred from Sources: line? Just like rpmbuild does? -- Tomasz Torcz There exists no separation between gods and men: xmpp: zdzichubg@xxxxxxxxx one blends softly casual into the other. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/7HHH2OS2Y22MVE3UGLXGRUCDEHKUODNB/
