Artur Iwicki wrote: > That section of the guide is a bit poorly worded. You should *not* use "git add" on source tarballs. These should be added only via means of "fedpkg new-sources $FILES; git add ./sources". I believe what the guide means under "new source files" is e.g. when upstream does not provide an icon or a .desktop or an .appdata.xml file (or a systemd .service or whatever) and you add your own. This does not include "new upstream release tarball". > > I'll try to think of some way to make that more clear and submit a suggestion to change the guide text. Somewhat tangentially, it may be worth recommending that the .gitignore be edited suitably for the project as one of the first steps in maintainence. By default 'fedpkg sources' will add the files being added to the lookaside cache to the .gitignore, but it will never remove older files, leading to an unnecessarily large .gitignore file. It's much more legible to use git's pattern matching facilities to match the source files. For example, the rpmlint's .gitignore contains the following¹: /*.rpm /results_rpmlint/ /rpmlint-*/ /rpmlint-*.tar.gz This keeps 'fedpkg source' from needing to add each new tarball to the file. More importantly, it makes it harder to accidentally add a tarball to git. The additional rules are convenient for ignoring other files and directories which are often present in the work tree but are never intended to tbe committed. Refer to gitignore(5) for details on the pattern matching rules. ¹ https://src.fedoraproject.org/rpms/rpmlint/blob/master/f/.gitignore -- Todd ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ If people are good only because they fear punishment, and hope for reward, then we are a sorry lot indeed. -- Albert Einstein
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/UVNDIPPZNOP3JLQILZEF2KEIJGRHRDK5/
