On Fri, 22 Jun 2018 09:37:15 -0600 Jerry James <loganjerry@xxxxxxxxx> wrote: > On Thu, Jun 21, 2018 at 2:50 AM Daniel P. Berrangé > <berrange@xxxxxxxxxx> wrote: > > Fedora rawhide has not had any kernel build available for i686 for a > > week now. It was disabled in a rebase due to part of the build > > process segfaulting. > > The bug causing the segfault is not specific to i386. It could happen > on any architecture. There is an incorrect loop termination condition > that can lead to an array index wrapping around to (size_t)-1. Try > the attached patch. It fixes the issue for me. (I tried to mimic a > git-produced patch without actually having a git checkout of the > kernel handy. If somebody wants to generate that patch the right way > and submit it upstream, that would be great.) Doesn't that error (nread wrapping) imply that the file being read is empty, except for some trailing newlines? I think your fix is just a workaround for a bad input file. It's great to deal with a corner case, but wouldn't the issue be why the file being read is empty except for trailing newlines (when it isn't on any other arch). I don't understand the purpose of the routine, but the name cmd implies the file is supposed to contain a command of some sort. It would also work if it was completely empty (no trailing new lines). _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/7XFLPGFX3ARVC7DOAGA6JIWQF2JSTD3G/
