On Fri, Feb 16, 2018 at 6:43 AM, Tom Hughes <tom@xxxxxxxxxx> wrote:
On 16/02/18 12:36, Tomasz Kłoczko wrote:
On 16 February 2018 at 11:21, Panu Matilainen <pmatilai@xxxxxxxxxx <mailto:pmatilai@xxxxxxxxxx>> wrote:
[..]
Not everybody runs rpmlint for everything they produce, on the
contrary I suspect it's fairly small percentage of packagers out
there that do. If rpm itself doesn't directly complain about such
things they'll simply never get cleaned up.
And this is why for example calling rpmlint should be one of the pre steps done by koji on sending build request.
It would be good to perform at least one time a month rpmlint test across all packages, and if it anything wrong automatically should be created git issue or bugzilla ticket.
Well rpmlint would need to be made a lot better first. The rate of
false positives at the moment is enormous.
In fact pretty much any non-trivial package has rpmlint warnings
which are no problem at all, even if only spellcheck issues.
I think it would be better to have fedpkg run rpmlint on "fedpkg build". It can be informative only. At least then it would not require the maintainer to run rpmlint themselves.
One thing I started doing was ALWAYS using spectool to download the new sources for an update before doing a fedpkg upload-sources. I found that the download links moved from time to time with some upstreams. That way I know my source URL is good.
Thanks,
Richard
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
