-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Fri, 2018-02-09 at 08:57 +0100, Pavel Raiskup wrote:
> On Thursday, February 8, 2018 5:02:10 PM CET Igor Gnatenko wrote:
> > Hello everyone,
> >
> > It seems that a lot of people have %file, %check, %build, %whatsoever in
> > their
> > changelog section.
> >
> > Is there any reason I should not go and automatically escape them?
>
> There's IMO no good reason why you should.
>
> I wouldn't use proven packager rights if the package builds fine. Fill a
> pull request if anything.
Then I have doubts that %changelog means anything because whoever uses rpm --
changelog would see unexpanded macro so if you had %autosetup -p1 in there,
users would see real commands instead... And also it might break in some cases
which requires maintainer intervention.
Also I don't see reason why I should send PR for ~500 packages where most of it
won't be merged ever. And this will create much more problems for me to track
this issue rather than just going and fixing all of them.
> One could admit that fixing similar typos (white space issues, spelling
> issues, changelog date issues, ...) is OK if you are touching the spec
> file anyway because of some real problems, but even then you make the
> patch less readable - and thus you raise chances that something get's
> overlooked. So I wouldn't do that.
>
> > %check → %%check
> > %build → %%build
> > %whatsoever → %%whatsoever
> >
> > There might be valid use-cases, but I'm not sure if they really are:
> > %{_localstatedir}/ft/ → %%{_localstatedir}/ft/
> >
> > Thoughts?
>
> E.g. server-side git hook refusing commits "adding typos" into changelog
> would solve it once and forever. If you were able to implement some
> systematic change like this then I would excuse the walk across all the
> spec files to fix old issues..
https://pagure.io/releng/issue/7300
- --
- -Igor Gnatenko
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlp9Wv0ACgkQaVcUvRu8
X0wgEg/+K6D6X+LtU6WG9wO2uLl8vhx0KjxhHGMKJmp6Fwd6OZ1ZsIXd0su0veuA
CuGRxu6nphmGPg5ElwR+J1jdz4hBK/Hwqju1XZNNCgg56vLrA8OPVFzLlKoBPfqF
YDYfkh91AouECRdowwCeLfUS6pgOFZSlhdptrEusxSBcToL9HtwIf3AtOpUmIi+c
mBZ4TBWmt+4ik12tLR4Up7+n5a/dichEOx3Loq7RFPEOfjvBhudU/MZpn1b0Kf/P
vN8ocKoKbMvuHotHvBvp/j4BhsTIphvXr7Yg7DFItOTu18wfE+xr0DjWr3RZjxjF
bUIUJX4V9SRZHBBHJ6e4lwmifHtOLTlW/wW0d7pQvDKduw5ek0D0Bm/y5I/FEHwa
moY73GB7iQzIUMXOa12X1UyCnPvn3yw1WcBB/90QxovrAfAfYaPgKZmenVqwMapL
B4PKPHnbH2VqkFheZgBifixCL0ENSj35K+xgowQTkWJ1/0ZCXT+U1ihQh951zYF3
Jb7lSKJSVMvp96HgR8vYBQQL34sYM7/cL1/N0BMis3NFjPc0DYbMuVRp0pbuRs0/
XT04F/lTvYBRUbW5wBgY5ss/+kiVVTZLmRaoJXBEbf1fh79d3il5O7oHugYhbCBn
+U927O5rR38EdERBV7BofY1kmoQE9nrki4ZWX3PAyc1muUCvxZM=
=greE
-----END PGP SIGNATURE-----
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
