On Tue, 2018-01-23 at 08:42 -0700, Jerry James wrote: > > There are no instructions on how to use it on this wiki page. Okay, > we'll try using --help: > > $ waiverdb-cli --help > Usage: waiverdb-cli [OPTIONS] > > Creates new waivers against test results. > > Examples: > > waiverdb-cli -r 123 -r 456 -p "fedora-26" -c "It's dead!" > > Options: > -C, --config-file PATH Specify a config file to use > -r, --result-id INTEGER Specify one or more results to be waived > -p, --product-version TEXT Specify one of PDC's product version > identifiers. > --waived / --no-waived Whether or not the result is waived > -c, --comment TEXT A comment explaining why the result is waived > -h, --help Show this message and exit. > > > Ooooookaaaaaay, so what is a result-id and how do I figure out which > one I need to supply for my particular case? It's how resultsdb identifies a single specific result. Each result in resultsdb has one, and they're unique. However, I see an obvious problem here: I can't see any easy way to figure out the result ID of the failure from the Bodhi web UI. The URL you get taken to when you click on the test result in Bodhi doesn't include it, so far as I can see. You *can* actually find the failed test quite 'easily' from the resultsdb web UI, but you have to know how to do it: go to the search page - https://taskotron.fedoraproject.org/resultsdb/results - and enter the package NVR (gap-pkg-io-4.5.1-1.fc27) as the 'item', and dist.abicheck as the 'testcase', then search, and you'll find it. Then click 'details' and you can see the ID is 18913262. But that's obviously not an ideal workflow! As Pierre said, they're working on hooking this all up from the Bodhi web UI so waiving will be a much easier process. > I can guess what a > product-version is, but why is it in a different format from every > other Fedora tool that takes such a thing? Because that's the form PDC uses; waiverdb works with PDC, and PDC chose its format a while ago, so that's kind of plumbed in now. > How do I point this tool > at the update of mine that is currently being blocked? At least AIUI, you don't actually have to: all that matching logic is performed by the various systems involved. Basically, Bodhi asks Greenwave if the update is good to go; Greenwave asks ResultsDB for tests associated with the update, and asks WaiverDB for waivers associated with those tests. So its answer to Bodhi will take the waiver into account. All you have to do is submit the waiver. > Where are the instructions? Why is informing packagers, the group > most affected by this change, an afterthought? We should have been > told about all of this, in detail, prior to the thing being turned on, > *well* before it was turned on. So, my answer to this is second-hand - apologies if any of it is wrong, and the folks involved will no doubt correct me. But as I understand it, I think they weren't really expecting the tests that were turned on to have false positives; the tests that were chosen were intended to be ones that wouldn't cause this kind of problem, so there'd be more time to get all the waiverdb integrations in place. I don't think they actually anticipated that false positives would happen and people would need to use waiverdb-cli like this, which is why instructions for it weren't part of the plan. I'm sure no-one intended to cause disruption and inconvenience, and we're sorry about it. I'll try to ask the relevant folks if perhaps we should stop gating on the abidiff test for now as a short-term measure, or something like that. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
