On Tue, Jan 23, 2018 at 08:55:03AM +0000, Richard W.M. Jones wrote: > On Mon, Jan 22, 2018 at 05:36:56PM +0100, Igor Gnatenko wrote: > > * Removes exectuable bit (and shows warning) for files where there are no > > shebang > > The way this is written implies that ordinary (eg ELF) executables > will be broken by this change, which I'm assuming/hoping is not the > case. > > I'm concerned that your changes will break mingw-* files, where the > executable bit is set on something which is neither a shebang script > nor an ELF executable. (There are other corner cases too, > eg. programs which are meant to be run under qemu or wine). In the PR it appears to filter on executuable files with a detected mime type 'text/*', and thus it should skip binary files whether ELF or any other format. This looks like it should be safe for mingw files. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
