On 01/23/2018 10:55 AM, Richard W.M. Jones wrote:
On Mon, Jan 22, 2018 at 05:36:56PM +0100, Igor Gnatenko wrote:
* Removes exectuable bit (and shows warning) for files where there are no
shebang
The way this is written implies that ordinary (eg ELF) executables
will be broken by this change, which I'm assuming/hoping is not the
case.
I'm concerned that your changes will break mingw-* files, where the
executable bit is set on something which is neither a shebang script
nor an ELF executable. (There are other corner cases too,
eg. programs which are meant to be run under qemu or wine).
Yes, this sounds somewhat dangerous and also out of scope for a script
whose purpose is to mangle shebangs.
It's perfectly okay to *warn* on executable files that look like there's
a missing shebang (or shouldn't have executable bit set) but leave the
bits alone.
- Panu -
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
