On Mon, 2018-01-22 at 19:19 +0100, Florian Weimer wrote: > On 01/22/2018 06:26 PM, Adam Jackson wrote: > > > > I'm trying to prepare xserver for this change, and it seems to provoke > > an awkward warning when building on F27: > > > > In file included from ../os/rpcauth.c:47:0: > > /usr/include/tirpc/rpc/rpc.h:83:12: warning: redundant redeclaration of ‘bindresvport’ [-Wredundant-decls] > > extern int bindresvport(int, struct sockaddr_in *); > > ^~~~~~~~~~~~ > > In file included from /usr/include/tirpc/rpc/rpc.h:40:0, > > from ../os/rpcauth.c:47: > > /usr/include/netinet/in.h:502:12: note: previous declaration of ‘bindresvport’ was here > > extern int bindresvport (int __sockfd, struct sockaddr_in *__sock_in) __THROW; > > ^~~~~~~~~~~~ > > > > Is there any reasonable fix for this? > > Redeclarations in system headers are expected. Do you compile with > -Wsystem-headers? Or do you something else which is unusual, such as > running the preprocessor separately? Not that I'm aware of. The generated cc line is: ninja: Entering directory `build' [1/17] ccache cc -Ios/libxserver_os@sta -Ios -I../os -Ixfixes -I../xfixes -Irender -I../render -Irandr -I../randr -Ipresent -I../present -Iinclude -I../include -Idri3 -I../dri3 -Idbe -I../dbe -Imiext/sync -I../miext/sync -Imiext/shadow -I../miext/shadow -Imiext/damage -I../miext/damage -Imi -I../mi -Iglamor -I../glamor -Ifb -I../fb -Iexa -I../exa -Idamageext -I../damageext -Icomposite -I../composite -IXi -I../Xi -IXext -I../Xext -I/usr/include/X11/dri -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/tirpc -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu99 -O2 -g -DHAVE_DIX_CONFIG_H -fno-strict-aliasing -fvisibility=hidden -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fPIC -D_DEFAULT_SOURCE -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -MMD -MQ 'os/libxserver_os@sta/rpcauth.c.o' -MF 'os/libxserver_os@sta/rpcauth.c.o.d' -o 'os/libxserver_os@sta/rpcauth.c.o' -c ../os/rpcauth.c In file included from ../os/rpcauth.c:47:0: /usr/include/tirpc/rpc/rpc.h:83:12: warning: redundant redeclaration of ‘bindresvport’ [-Wredundant-decls] # ... Is -Wredundant-decls just not a thing one should try to use? - ajax _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx