-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Fri, 2018-01-19 at 14:01 +0000, J. Randall Owens wrote: > On 18/01/18 19:45, Sérgio Basto wrote: > > On Thu, 2018-01-18 at 20:17 +0100, Igor Gnatenko wrote: > > > Hello, > > > > > > I'm working on removing all this cruft from all our packages (and > > > creating > > > conditionals for all packages which have epel branch). > > > Unfortunately some maintainers adding them back with conditionals > > > like: > > > %if 0%{?fedora} < 28 || 0%{?rhel} < 8 > > > > > > 1. Those scriptlets are not needed since ~ F24 era > > > 2. You might not know, but 0%{?rhel} on Fedora evaluates to "0" which > > > is "< 8", > > > so those scriptlets are active. > > > > > > Also forgive me if your package had some EL* specific conditions and > > > I removed > > > scriptlets (because there was no epel* branch) -- please use > > > %if 0%{?rhel} && 0%{?rhel} <= 7 > > > > > > for them. > > > > Hello , > > BTW I have some questions on how exactly we should deal with EPEL 7 and > > 6, from old wiki page [1] desktop-database and mimeinfo have been > > removed and Icon cache too ? IMHO these info should still be in wiki > > and not deleted, maybe also should explain the status on EPEL versions > > ... > > > > Maybe more correct scriptlet is: > > %if 0%{?fedora} < 25 && 0%{?rhel} < 8 > > I'm not even the best at bash, much less the scripting in spec files, > but is it possible this would be a problem because e.g. Fedora 26 would > be evaluated as 026, which would evaluate as octal, and therefore the > conditional evaluate as 22 < 25, true, when it was meant to be false? 1. it is not evaluated by shell 2. in RPM there is no built-in support for octal numbers > > > > And about appdata how exclude it from EPEL 6 ? > > > > %if 0%{?rhel} > 6 || 0%{?fedora} ? > > > > I'd like that we have some "official" scriptlets for that. > > > > Best regards and thanks. > > > > [1] > > https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4684 > > 84#mimeinfo > > > > > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx - -- - -Igor Gnatenko -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlph/V4ACgkQaVcUvRu8 X0yOxQ/7BVCKvC4E1RmRL3nS0+2RjZTXlYbGEvDJbcHgUvgeobp0VAHKWPVXLcUD yj5fHcp0N4C6Hum1QNG7ZOpjCCSUsM8EFq+apNUaFxIkSxY9dPfnqxRIE39pLQOc 0NBKr/AOMfETPTtN+EhXckcF6Kv6gxUyEox0rmWR71h6oIgOEwDXcBkiBWiOGTfp 2IfmDM+Ykd1/lT3PhUDH6Ae1xLhTgzNj+4waq2zLcQJqH91/19quPXpS8XSZecKw FjizS+P0gXDvY25UdNrafOJmS0uDap2bia2uOHEgYhVkXIcaF4ZrLtL7iR+dqPuR 3ejrLpWyEsI4qsQUZCxNR2NG15hscHkEFc1gV/E/3BuRSD+iyb5fDkHec/0lvCkB cvfkQ7D5EbiDL210RqOx/WGhFcDVZtJMU8SaLMGJBY5LjYFzkEfqtHMCOlU379XB INa0uFkuxG1gjbP9IhOsChz5XqskwXbMpBKhHXQ3Wf/omnwdv6jWSJcJYZ2LTAE2 YZT6b+vNIas5WjXTvWPIo9re8r/hXM6m8x4Wl/U/QqV0Q7ODsIIjHh/lJPd7ti+5 9tFgoA7YxzT2CNUlyjgK9JTj5YqRhf9POpjUJtwOwp/PMpu5DGAVZcYJlBawXpdF PMf1HSqymzNhxXUvcr1ofp4pX1okjgD2g0YEyu3tJeMPJE7yHZY= =SwUu -----END PGP SIGNATURE----- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx