-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On Thu, 2018-01-18 at 19:45 +0000, Sérgio Basto wrote:
> On Thu, 2018-01-18 at 20:17 +0100, Igor Gnatenko wrote:
> > Hello,
> >
> > I'm working on removing all this cruft from all our packages (and
> > creating
> > conditionals for all packages which have epel branch).
> > Unfortunately some maintainers adding them back with conditionals
> > like:
> > %if 0%{?fedora} < 28 || 0%{?rhel} < 8
> >
> > 1. Those scriptlets are not needed since ~ F24 era
> > 2. You might not know, but 0%{?rhel} on Fedora evaluates to "0" which
> > is "< 8",
> > so those scriptlets are active.
> >
> > Also forgive me if your package had some EL* specific conditions and
> > I removed
> > scriptlets (because there was no epel* branch) -- please use
> > %if 0%{?rhel} && 0%{?rhel} <= 7
> >
> > for them.
>
> Hello ,
> BTW I have some questions on how exactly we should deal with EPEL 7 and
> 6, from old wiki page [1] desktop-database and mimeinfo have been
> removed and Icon cache too ? IMHO these info should still be in wiki
> and not deleted, maybe also should explain the status on EPEL versions
> ...
It now lives on separate page: https://fedoraproject.org/wiki/EPEL:Packaging?rd
=Packaging:EPEL#Scriptlets
> Maybe more correct scriptlet is:
> %if 0%{?fedora} < 25 && 0%{?rhel} < 8
1. F24 is EOL for long time, absolutely no need to include that in scriptlets.
2. Leaving just %if 0%{?rhel} < 8 is wrong because essentially it is %if 0 < 8,
you need to use %if 0%{?rhel} && 0%{?rhel} < 8 instead.
> And about appdata how exclude it from EPEL 6 ?
>
> %if 0%{?rhel} > 6 || 0%{?fedora} ?
To be honest, I prefer using %if ! (0%{?rhel} && 0%{?rhel} <= 6), because
everything except RHEL6 supports metainfo/appdata (not rhel7+ and fedora).
There are people using same specs (from Fedora), for example in Mageia. I don't
think that we should make their life more complicated. Even if you don't care
about them, it's not big deal to write "forward looking conditional" I think.
> I'd like that we have some "official" scriptlets for that.
>
> Best regards and thanks.
>
> [1]
> https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=468484
> #mimeinfo
Obviously, I can't force you to do it this way, but I think that this is good
practice.
- --
- -Igor Gnatenko
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlpg/asACgkQaVcUvRu8
X0yATA/+L4qZSvuM4lNxtrpquhToYtcYjOtuYCqiHRVZyZkNRuCHin4plEzS/dTw
mECQmKKmOChtZQi1JsJPwiCgy8NwAurI8Mdfxh3LD9hRVBwzWga6idh4w5wRBbK4
lPjmSfTBmuRhVr8yn0hpPhpiFaQLyfFC/nClQ2BLzL97i/LSfAT6O6qR5z8a37uP
luD9HJ1wjTryCGYUPvz3KLMGrylz/ftu7jwwMhwf7HcA8Rr5wR2ZoRXxOjTuEdUR
bmgMaxgijv+DH/whwDc34RXk6xyMWdSuPgS4gh4Kv6mnxX3K6POAGoOrxysJyYsW
ZG70+cV8gooQYL3dp8BvPdDAfKJDncSFS46GYp0nOmlNvk2qVK98x4740uVpV5vo
NxmoVd0EfLaiTD/jTtQdPND44s+R8nB8a/GNId7xBTp7GOfJhKRndwsQj01qgy00
Mw3iApsoTb13N1PqoJnt/hUFe45hTHXuYJWCtSM3dEJBe+bmbFQSMI5Kw9jM5aWg
i7hJRaop4ygvPjidIDG2688XI+h4BLS1JDPfoq030bA1zvJbs4VtndlPa17NlHgb
sO8YsLzTiA/QSouIfyORVKeCLD5cwS34B/ma3MuaFSmDCB9LPdpuZwsXBtbocKht
oSDDfb3GPzcSmFam8r4UwJPxSqXrwsp/Ow3W27R1sbtjdss2ADY=
=8zON
-----END PGP SIGNATURE-----
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
