>>>>> "JK" == Jan Kurik <jkurik@xxxxxxxxxx> writes: JK> Python 2, when called as python or /usr/bin/python at RPM build time JK> (as identified by the RPM_BUILD_ROOT environment variable), will JK> print a deprecation warning to stderr. (Any program invoked during JK> build that invokes /usr/bin/python will cause this warning as well.) I applaud the effort and think the idea is a good one. However, I'm vaguely uneasy about hanging this off of the seemingly unrelated RPM_BUILD_ROOT. My initial idea was to simply decide on another variable to use such as AMBIGUOUS_PYTHON_VERSION_WARNING, and then set that in our rpm configuration. (Most likely in %__build_pre, which is defined by the macros in the rpm package, not redhat-rpm-config.) But it occurs to me that in the end this has the same result; you get complaints even if you're building non-Fedora packages (where our guidelines don't apply). It's just that the involved variable is slightly more obvious. I guess if we did that Python would only need to check one environment variable, but that's not really much of a concern. It would also mean that "unset RPM_BUILD_ROOT" would never occur to someone as a potential solution. In the end I just can't shake the notion that it's bad to have some random non-python-related environment variable basically breaking python. - J< _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
