On 24/05/17 17:58 +0200, Zdenek Dohnal wrote:
On 05/24/2017 05:49 PM, Jonathan Wakely wrote:On 24/05/17 17:32 +0200, Zdenek Dohnal wrote:Hi, I was doing rebase for gutenprint pre-release in recent rawhide (fc27) and I couldn't build it because I had %VERSION macro defined by myself and it got rewritten by default macro %version. That indicates rpm macros have been case insensitive since fc27 (colleague told me the same situation is in fc26 too, but I encountered it in fc27).Isn't this because "Version" is the name of a tag? Just like Name and Release. And Tag names are not case-sensitive, so you could write this in your spec file: VERSION: 12.34 Reusing those for your own macros seems like a very bad idea and bound to lead to confusion. Does %version refer to the VERSION tag? Or does %VERSION refer to that?%{VERSION} contains %{version}-%{prever}. AFAIK macro %{version} contains value for Version: tag, so I defined other macro %{VERSION}. And I thought macros are case sensitive. I worked fine this way before.
And my point is that "the Version: tag" is not case-sensitive, so can
be written in a spec-file as VERSION: or VeRsIoN: or any other
variation, so defining any macro like VERSION of version or Version is
a bad idea. It can only lead to confusion.
Wouldn't %{PKG_VERSION} or %{VERSION_EXTRA} or something be a better
name for your macro?
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
