Re: Dealing with the toolchain detection issue breaking Rawhide (#1401231)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adam Williamson wrote:
> Yes, it's really bad. Look at the list of bugs marked as depending on
> it:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1393164 (owncloud)
> https://bugzilla.redhat.com/show_bug.cgi?id=1401172 (libldb)
> https://bugzilla.redhat.com/show_bug.cgi?id=1401175 (libtdb)
> https://bugzilla.redhat.com/show_bug.cgi?id=1401886 (gnome-shell build
> failed because of libtdb issue, breaking GNOME on Rawhide)
> 
> Installs of virtually any Rawhide package set besides minimal are
> broken (because they all run through samba, libldb, or both). Many
> package builds cannot run because they run through samba or libldb or
> libtdb.

Also, kdelibs3 failed to build due to its configure check for PCRE failing. 
I worked around it with:
export CFLAGS="%{optflags}"
to just remove the offending flags.

But I concur with Jakub Jelinek that there are probably tons of legacy 
configure scripts silently broken by this change (silently as in, the 
package will build with missing features, with only a warning in the 
build.log that nobody reads), and also a lot of build failures.

Unfortunately, custom autoconf checks are really bad offenders when it comes 
to not declaring things as you're supposed to. It used to be a common 
practice to never declare anything in autoconf snippets.

This really sucks because those flags would be the right thing to do in 
principle, especially -Werror=implicit-function-declaration. Those implicit 
declarations are very dangerous and NOBODY should use them anymore. But as 
things are in practice, adding the -Werror=implicit-function-declaration 
flag breaks just too many things. But I do not see this changing any time 
soon, legacy code with no more upstream such as kdelibs3 will never be 
fixed.

        Kevin Kofler
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux