Re: Help needed to fix open-vm-tools for GCC 6 to unblock Rawhide Workstation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jerry James wrote:

> On Fri, Apr 22, 2016 at 3:37 PM, Jerry James <loganjerry@xxxxxxxxx> wrote:
>> Change the definition of VMW_BIT_MASK in lib/include/x86cpuid.h to this:
>>
>> #define VMW_BIT_MASK(shift)  ((int)(long)(((1UL << (shift - 1)) << 1) -
>> #1))
> 
> No, make that:
> 
> #define VMW_BIT_MASK(shift)  ((int)(long)(((1ULL << (shift - 1)) << 1) -
> #1))
> 
> It's got to be long long, because long is still only 32 bits on 32 bit
> systems.  Sorry, I've gotten too used to working on 64 bit systems.

No, make that:

#define VMW_BIT_MASK(shift)  ((int)(long long)(((1ULL << (shift - 1)) << 1) - 1))

:-)

You forgot to also change the cast to match.

        Kevin Kofler

--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux