Help needed to fix open-vm-tools for GCC 6 to unblock Rawhide Workstation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Poking around the current compose status, I noticed that aside from the
freerdp thing I just sent a mail about, another thing is blocking
Rawhide Workstation live image compose:

https://bugzilla.redhat.com/show_bug.cgi?id=1305108

open-vm-tools-desktop is pulled into the Workstation lives. It requires
ICU. So since ICU was bumped to 57.1, the Workstation lives have failed
to compose because open-vm-tools-desktop has a broken dependency on ICU
56. We can't rebuild open-vm-tools because of that bug.

Upstream bug:

https://github.com/vmware/open-vm-tools/issues/67

the relevant code is here:

https://github.com/vmware/open-vm-tools/blob/master/open-vm-tools/lib/include/x86cpuid.h#L899-L932

GCC 6 does not like this:

#define VMW_BIT_MASK(shift) (((1 << (shift - 1)) << 1) - 1)

it produces errors:

/builddir/build/BUILD/open-vm-tools-10.0.0-3000743/lib/include/x86cpuid.h:912:51: error: result of '-2147483648 << 1' requires 33 bits to represent, but 'int' only has 32 bits [-Werror=shift-overflow=]
 #define VMW_BIT_MASK(shift)  (((1 << (shift - 1)) << 1) - 1)
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux