On Thu, Nov 12, 2015 at 4:57 AM, Tomas Tomecek <ttomecek@xxxxxxxxxx> wrote: > Quoting Adam Miller (2015-11-10 19:08:25) >> Cockpit's Dockerfile repo in DistGit would be stored with a >> leading special character: >> fedpkg clone -cockpit >> > > How about > > $ fedpkg clone cockpit-docker > > > Pros > > * no need to change infrastructure > > * easy to use > > * repo name suggests content I do like this, but I almost think if we were going to go this route we should have a policy around naming a container in DistGit with a prefix. I'd then suggest something like "ctr" to mean "container": $ fedpkg clone ctr-cockpit We would however need to request some kind of gating mechanism in pkgdb to make whatever the prefix is be a "reserved word" that wouldn't become the name of package in the future or else it would cause havok. Another thing that was mentioned to me was if we have separate DistGit instances containing packages and containers named the same thing that koji would be unhappy so that's definitely something we need to keep in mind. > > Cons > > * not a different namespace (in fact same namespace as rpms) > > * someone can do `fedpkg clone cockpit-docker && cd cockpit-docker && fedpkg > build` and get scared that it doesn't work > > * `build` could be aware of Dockerfile and run `container-build` actually > > * error could suggest using different build method I'd vote for a detection of Dockerfile without a spec file error out and suggest an alternative build method. > > > What's the way of building (qcow, docker base) images? Could that approach be > resued? (meaning, what's the way of storing kickstart files atm?) Currently the kickstarts are flattened and passed to the koji image-build command as a parameter, they are all stored as part of the spin-kickstarts[0] fedorahosted space and aren't really managed at all like DistGit. -AdamM [0] - https://fedorahosted.org/spin-kickstarts/ > > > ~~ > Tomáš Tomeček > Software Engineer > Developer Experience > UTC+2 (CEST) -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
