On Tue, 2014-02-25 at 15:45 +0100, Matthias Runge wrote: > On Tue, Feb 25, 2014 at 08:50:18AM -0500, Adam Jackson wrote: > > This is an argument against %check, not against testing in general. We > > should be relying on rpmbuild less, not more. rpm doesn't even have > > anything like Requires(check), does it? > > Hmm, then we should probably about enhancing this? Like adding a > separate phase of for %check to rpmnbuild? This is exactly not "relying on rpmbuild less", so no, I don't think we should do that. I was attempting to use rpmbuild's existing inadequacy as an argument for not bothering with it, not suggesting we enhance a bad tool. > IMHO, that still belongs to building a package, as I don't want > a package pushed, when checks are not executed successfully. You are failing to distinguish between "pushed to package git" and "pushed to an installable repository", which is a mistake. - ajax -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
