On Tue, Feb 25, 2014 at 08:50:18AM -0500, Adam Jackson wrote: > On Tue, 2014-02-25 at 12:45 +0200, Alexander Todorov wrote: > > > 1) Do we consider this a bug and if yes what priority do you give it? From last > > week discussions it looks like most people prefer to have tests executed in %check. > > I don't consider %check to be an appropriate way to run tests, so no, I > don't consider it a bug. Stating it broadly: we don't have a separate > phase for it in koji, which means we can't adequately set up tests in > general; and adding it to koji would be a mistake, because build > construction and build validation are fundamentally different phases. > > This is an argument against %check, not against testing in general. We > should be relying on rpmbuild less, not more. rpm doesn't even have > anything like Requires(check), does it? Hmm, then we should probably about enhancing this? Like adding a separate phase of for %check to rpmnbuild? IMHO, that still belongs to building a package, as I don't want a package pushed, when checks are not executed successfully. Checks could be executed in a different phase, e.g before acutally pushing to a repo. Separating from build would have another benefit: being able to execute tests, e.g when required packages were updated. That'd require significant changes in our infrastructure and in many packages, as test suites and test data currently don't belong to most packages. -- Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
