On Fri, Dec 13, 2013 at 06:42:11PM -0700, T.C. Hollingsworth wrote: > Invariably when adding a patch to a spec, often I forget some detail, > whether it be adding the %patchN macro to %prep or `git add`ing the > patch. It would seem I'm not alone, either. A Google search for e.g. > "site:https://lists.fedoraproject.org/pipermail/scm-commits/ really > apply patch" returns tens of thousands of results! ;-) > > To prevent this from happening in the future, I wrote a little git > pre-commit hook to help out, which I figured I'd share with you all: > http://patches.fedorapeople.org/patchcheck.py > > It verifies that: > - all patches are committed to git > - all patches are applied in %prep > - no unexpanded %patch macros exist in %prep > > If any of the above checks fail, the commit is aborted. It would be nice also to check that the sources file contains the Sources listed in the spec file, since I often bump the version number and forget to upload the new sources. Also somewhat related: https://lists.fedoraproject.org/pipermail/devel/2013-November/thread.html#192201 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
