Re: Fwd: [mirall] plasma client try3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Joseph Marrero wrote:

> From: Joseph Marrero <jmarrero@xxxxxxxxx>
> Date: Wed, Mar 6, 2013 at 11:40 PM
> Subject: Re: [mirall] plasma client try3
> To: Kevin Fenzi <kevin@xxxxxxxxx>
> 
> 
> I am preparing the package for upstream merge between mirall and
> owncloud-plasma-client


Looks like the root cause is more likely this snippet from 
src/CMakeLists.txt:

    install(TARGETS owncloudsync
        RUNTIME DESTINATION bin
        LIBRARY DESTINATION lib
        ARCHIVE DESTINATION lib
        BUNDLE  DESTINATION library
    )

contrast this with similar (and imo better) snippet about mirall:

    install(TARGETS mirall
        RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
        LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
        ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
    )

See how the former hard-codes relative paths bin and lib?  (not good, from a 
packaging-perspective anyway)

-- rex

-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux