On 2/19/13 6:48 AM, Petr Pisar wrote: > On 2013-02-18, Eric Sandeen <sandeen@xxxxxxxxxx> wrote: >> >> Anyway, if you want to check your package(s) and maybe make them >> 64-bit-stat safe, the perl script above might help. It's more than >> just -DFILE_OFFSET_BITS=64, since you'll need to be sure not to >> overflow any large values you get back from stat64 etc. >> > Is %configure spec macro the right place to define FILE_OFFSET_BITS? I don't think so, because then rather than getting an (unpleasant but predictable) EOVERFLOW from the syscall, you might overflow local variables and get even more random & unpredictable behavior for large files or inodes. Unfortunately, I think it's up to individual app writers to take care of, in order to do it properly and safely. -Eric > Because it breaks struct stat ABI, it should be defined on distrubition > level. For the same reason I can imagine upstream could be reluctant to > embed the defintion for everybody. > > -- Petr > -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
